Filter stale/out-of-range updates from get_updates#26
Merged
Conversation
Some beacon RPC providers return a malformed light_client/updates list when start_period is the current (in-progress) sync-committee period: they ignore `count`, prepend the head-period update, then dump their entire retained history (~200 older periods), out of order. helios passes this through unsorted, so the SP1 program receives a stale update as entry #2 and verify_update rejects it with InvalidPeriod ("Update 2 is invalid!"), aborting the run. Defend against the non-compliant response by keeping only updates whose sync period is >= the requested period and sorting ascending, so they form a clean chain starting from the store.
prabal-banerjee
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some beacon RPC providers return a malformed light_client/updates list when start_period is the current (in-progress) sync-committee period: they ignore
count, prepend the head-period update, then dump their entire retained history (~200 older periods), out of order.helios passes this through unsorted, so the SP1 program receives a stale update as entry #2 and verify_update rejects it with InvalidPeriod ("Update 2 is invalid!"), aborting the run.
Defend against the non-compliant response by keeping only updates whose sync period is >= the requested period and sorting ascending, so they form a clean chain starting from the store.