Add Node.js 26 support; drop 25#3450
Merged
Merged
Conversation
novemberborn
commented
May 15, 2026
Comment on lines
+204
to
+207
| // FIXME: This seems to be a bug in cbor2, ignoreGlobalTags shouldn't break (Uint8)Array encoding. | ||
| const types = new TypeEncoderMap(); | ||
| types.registerEncoder(Array, writeArray); | ||
| types.registerEncoder(Uint8Array, writeUint8Array); |
Member
Author
There was a problem hiding this comment.
@hildjj FYI, something seems wrong here. It's late, so a proper bug report will have to come later sorry 😄 There's a related issue in the decode code path.
But, cbor2, yay!
External assertion snapshot cannot be updated, since AVA 8 emits corrupt snapshots with Node.js 26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/files in reporter logs