Repository navigation
fix(delay): clamp full-jitter ceiling to int64 range - #172
Merged
Merged
Conversation
JaSei
commented
Nov 4, 2026
JaSei
commented
Collaborator
FullJitterBackoffDelay panics with "invalid argument to Int63n" once the exponential ceiling exceeds math.MaxInt64 (attempt 34 with Delay(1s) and no MaxDelay). Converting an out-of-range float64 to int64 is implementation- defined in Go; on amd64 it yields a negative value that Int63n rejects. arm64 saturates, so the bug is invisible there. Saturate the ceiling at math.MaxInt64 before the conversion. Builds on the approach from #159. Co-authored-by: dualfroz <me@dualfroz.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
+ Coverage 97.47% 97.51% +0.03%
==========================================
Files 4 4
Lines 238 241 +3
==========================================
+ Hits 232 235 +3
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.