Repository navigation
Tint unplayed matches' Win Pred cell by prediction - #421
Open
Krish-Parmar22 wants to merge 1 commit into
Open
Krish-Parmar22 wants to merge 1 commit into
Krish-Parmar22 wants to merge 1 commit into
Conversation
Completed matches keep the existing green/red for a correct/incorrect prediction. Unplayed matches, previously white, are now tinted by the prediction itself: on a team page a pale green for a predicted win and a pale pink for a predicted loss; on an event page the light red/blue alliance tints already used in the row, by predicted winner. The unplayed tints are deliberately paler than CORRECT_COLOR / INCORRECT_COLOR so a prediction is visually distinct from a verified result in the same column. Closes avgupta456#321
|
@Krish-Parmar22 is attempting to deploy a commit to the avgupta456's projects Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321
Today the Win Pred cell is green/red for a completed match (prediction was correct/incorrect) and plain white for an unplayed one, so upcoming predictions have to be read rather than seen.
Change
frontend/src/components/MatchTable.tsx— the cell background is now computed once from match status and prediction:Win/Lose)Red/Blue)CORRECT_COLOR/INCORRECT_COLOR(unchanged)#DDF3E6/ pale pink#FDE1E2lightRed/lightBlue(the row's existing alliance tints)The issue asks for red/green. I used paler tints than the verified colours on purpose: the same column would otherwise use one colour for "we predict a win" and "we were right", which are different claims. On the event page the cell says the alliance name, so red/green there would be ambiguous — the alliance tints match the rest of the row.
Happy to switch to the full
CORRECT_COLOR/INCORRECT_COLORif you'd rather.Verified
next lint,tsc --noEmitpass. Checked in the browser with a local stub marking matches as unplayed (no real unplayed matches exist right now):2026dal_f1m3, a genuinely unplayed finals game 3 in the data, also colours correctly./event/2026cmptx→ Elim Matches: unplayed rows tinted light blue/red by predicted alliance; played rows unchanged.