Skip to content

chore(DB): remove the leftover skeleton acore_string file - #13

Merged
Helias merged 1 commit into
masterfrom
acore-string-locale
Oct 27, 2026
Merged

Helias merged 1 commit into
masterfrom
acore-string-locale

Conversation

@Helias

@Helias Helias commented Oct 27, 2026

Copy link
Copy Markdown
Member

Changes Proposed:

  • Removes data/sql/db-world/base/skeleton_module_acore_string.sql. It's the "Hello World from Skeleton-Module!" string copied over from the skeleton module, and this module never uses it.
  • After the core PR the file would fail to import, because it writes to the locale_* columns of acore_string that the PR removes.

Issues Addressed:

SOURCE:

Not needed.

Tests Performed:

  • Checked that nothing in src uses entry 35410.
  • Not built or tested in game.

How to Test the Changes:

  1. Install the module on a fresh world DB with the core PR applied: the module SQL imports without errors.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 88aa0793-0c7b-4091-acd8-b407cf479f6e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Helias
Helias merged commit a7705b2 into master Oct 27, 2026
3 checks passed
@Helias
Helias deleted the acore-string-locale branch October 27, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant