Improve autocorrelation plot - #217
Merged
Merged
Conversation
…rn to vertical panel to show y-axis better
Contributor
|
@mosesyhc Based on a previous conversation, it is my understanding that you no longer want this change to be incorporated. Please feel free to close if this is true. |
Member
Author
|
This is still a good modification, to help visualization. We should incorporate it. |
Synchronize feature branch
jared321
approved these changes
Jul 16, 2026
jared321
left a comment
jared321
left a comment
Contributor
There was a problem hiding this comment.
PR review
- Reviewed all changes made
- Ran test script with one 1D test problem showing visualizations to confirm that autocorrelation plot still good
- Confirm all actions passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of time lags to check (as 25 step lags are currently sufficient.) The y-axis is shown better by turning the horizontal panel into a vertical panel.
lag=0is always returning correlation = 1, which matches a standard autocorrelation plot and it also serves as a sanity check for the correct calculations of correlation.