Synchronize feature branch - #231
Merged
Merged
Conversation
Now the configuration is not tied just to MH. This percolated throughout the test script code so that we open the door to testing LMC and PTLMC. Test script ran through with no issues and the unit tests run through cleanly as well.
The results do not look good and I don't see any parameters for me to adjust. This fits with the fact that LMC is currently listed as research grade. This second set of tests fail because the sampler cannot yet be made deterministic. That will be done on a later branch.
Homogenize the argument list of PTLMC with that of other samplers. My test execution fails due to an array sizing issues I suspect. Moses should first update this test setup to see if it's any good and then check the error.
Synchronize feature branch
Synchornize feature branch to main
I was able to establish LMC and PTLMC benchmarks with these changes.
PTLMC test suite
This is the first step in updating the sampler interface. In the interest of minimizing the changes to the calibrators, this set of changes is intentionally only a partial step in that upgrade. This uncovered a potential issue in test_cal_samplers that required removing the testing of PTLMC. Moses will look into this before this branch is merged into main. MH, LMC, and PTLMC testing showed bitwise identical sampler results as expected. The unit tests are passing with PTLMC removed as detailed above.
…lers. These are, again, intermediate steps in the overall process of improving the sampler interface. unit tests and direct sampler tests still passing. Docs are rendering.
Ideally that section will be redone with a more modern procedure for using a user-provided sampler.
The docs are rough/wrong and the code isn't using any of this yet.
These changes would make comparing diffs unnecessarily hard for the PR review.
…n addition, to unset an RNG
… any collection-time error
(1) Ensure that no surmise RNG is used except within test functions (2) Reduce redundancy in calling shared variables from shared_scenario.py (3) Allow for fixtures to be called by test to ensure "no_rng" (RNG cleared), "seeded_RNG" (surmise RNG set properly)
As expected, the new results were not identical to the benchmark. However, the new results look reasonable.
Random draws not using the global RNG. Internal tests probably shouldn't override the underlying failure message, but rather only print more information to help understand the context of the failure. This should hopefully get actions passing again.
Implement new RNG scheme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainhas been updated since this branch was based off of it.