Skip to content

#710 - fix embeding images with multiple inline images#758

Open
Pyrol wants to merge 1 commit into
barbushin:masterfrom
Pyrol:patch-1
Open

#710 - fix embeding images with multiple inline images#758
Pyrol wants to merge 1 commit into
barbushin:masterfrom
Pyrol:patch-1

Conversation

@Pyrol

@Pyrol Pyrol commented Jun 17, 2026

Copy link
Copy Markdown

reposting request: bpali#1

after #580 ($contentId || 'inline') replaces every inline image within an email with the first one found. So fix #580 is invalid for that case.

Also a question if checking disposition is really necessary? If it is then i'd propose code below

$contentMatch = $attachment->contentId == $cid;
if ($attachment->disposition && !empty($attachment->disposition)) {
    $contentMatch &= 'inline' == \mb_strtolower((string) $attachment->disposition);
}

if ($contentMatch) {
//convert to base64 
image

reposting request: bpali#1

after barbushin#580  ($contentId || 'inline') replaces every inline image within an email with the first one found. So fix barbushin#580 resolution is invalid for that case.
@Pyrol Pyrol changed the title #710 - fix mails with multiple inline images #710 - fix embeding images with multiple inline images Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant