Conversation
This reverts commit 4f92837.
by bumping versions again
and convert the old WS event emitters to API endpoints for the dashboard
+ change typescript aliases from `@<module>` to `@/<module>` (ex: `@services` -> `@/services` to distinguish them from external npm packages
for security concerns
through `envalid`
barthofu
force-pushed
the
version/2.3
branch
from
February 21, 2024 00:13
5aa69e8 to
f7464eb
Compare
|
Using something like Deno or Bun could solve most of these concerns (hot reloading, building, speed). I fixed most of these issues on my fork, but not the hot reloading. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR is an attempt to
finalymigrate from CJS to ESM.Problem(s)
The most important problem is that ts-node (for dev) doesn't support
tsconfig.pathsaliases resolution in ESM. I've managed to quite fix that using a custom loader (./loader.js).We also want to keep the commands and events HMR.
What I've done so far
tsconfig.targetandtsconfig.moduletoesnexttsnodeconfig block in the tsconfig json filecasedep which was CJS-only withchange-case.resolveDependencies4.1 because of the error
Cannot access X before initializationSolutions
Notes