Prepare v0.12.0 take 2: re-run benchmarks, refactor example notebook - #182
Merged
Conversation
StepMemorySharded passes a mesh, but StepMemory.make_state also injected target_platform via a bartz<0.11.0 workaround. Current bartz treats the two as mutually exclusive, so init asserted and the sharded memory benchmark failed. Gate the workaround on no mesh being present. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
When lambda_ >= THETA_SPLIT the sampled k can exceed the pmf truncation, leaving pmf_k == 0 and inf tangent coefficients. Forward mode discards this branch, but the select transpose routes a zero cotangent into it (inf * 0 = nan), poisoning the lambda_ gradient. Guard pmf_k before dividing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The only significant regression is the compilation time with sparsity on, as expected due to adding augmentation.
Switch from `gbart` to `Bart` and minimize further the amount of code.
The refreshed example notebook runs with the default 1000 burn-in + 1000 saved iterations, i.e. 2000 total MCMC iterations. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Gattocrucco
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bartfromgbart