Skip to content

fix(archiver): shut down API server on stop#56

Open
Gercekkriptocu wants to merge 1 commit into
base:masterfrom
Gercekkriptocu:fix-archiver-api-server-shutdown
Open

fix(archiver): shut down API server on stop#56
Gercekkriptocu wants to merge 1 commit into
base:masterfrom
Gercekkriptocu:fix-archiver-api-server-shutdown

Conversation

@Gercekkriptocu

Copy link
Copy Markdown

Summary

Ensures the Archiver API HTTP server is shut down when the archiver service stops.

Changes

  • Stores the Archiver API server returned by httputil.StartHTTPServer
  • Shuts it down in ArchiverService.Stop()
  • Aligns the archiver service lifecycle behavior with the standalone API service

Why

The archiver service currently starts an API server but does not retain a reference to it, so Stop() cannot shut it down.

Fixes #55

fix archiver API server shutdown
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@Gercekkriptocu

Copy link
Copy Markdown
Author

This PR stores the Archiver API server reference and shuts it down during Stop(), matching the lifecycle behavior used by the standalone API service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Archiver API server is not shut down during service stop

2 participants