fix(archiver): store and shut down API server during Stop()#57
Open
erhnysr wants to merge 1 commit into
Open
Conversation
Fixes base#55 The HTTP API server started in Start() was only stored in a local variable and never assigned to the ArchiverService struct, so Stop() could not shut it down. Add an apiServer field to ArchiverService, assign it in Start(), and call Stop(ctx) on it during service shutdown — consistent with how the standalone API service in api/service/service.go handles shutdown.
Collaborator
🟡 Heimdall Review Status
|
Author
|
Hi! Following up on this one too — fixes the API server not being stopped during Stop(), which can leave a dangling listener. Happy to rebase or adjust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55
Problem
The HTTP API server started in
Start()was stored only in a local variable and never assigned to theArchiverServicestruct. As a result,Stop()had no reference to it and could not shut it down.This could cause:
Fix
apiServer *httputil.HTTPServerfield toArchiverServiceStart()apiServer.Stop(ctx)call inStop()This is consistent with how the standalone API service in
api/service/service.goalready handles shutdown.