feat: pyo3 support module prefix + naming #3726
Conversation
andyscott
force-pushed
the
ags/pyo3-module-path
branch
from
7a660ad to
3a98fed
Compare
andyscott
changed the title
andyscott
force-pushed
the
ags/pyo3-module-path
branch
from
35bc452 to
e19bd9c
Compare
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
Thanks! Just one question
UebelAndre
left a comment
UebelAndre
left a comment
There was a problem hiding this comment.
One more question for you guys!
| name = "module_prefix", | ||
| srcs = ["bar.rs"], | ||
| edition = "2021", | ||
| imports = ["."], |
There was a problem hiding this comment.
Can you explain how this interacts with imports? Is imports = ["."] required? What happens if a subdirectory is added? Does it make the module not imported?
There was a problem hiding this comment.
Import values behave just like they do for regular Python library import paths under Bazel.
I reworked the test to use the default import path (the repo root) instead of the package's dir. The python test case is adjusted accordingly so it looks like the rest of the test cases in the pyo3 extension workspace.
There was a problem hiding this comment.
What happens if a subdirectory is added? Does it make the module not imported?
As in something like imports = ["some_dir"]? It'd try to strip this off of the prefix of the module path for python. Since the shared lib is being placed in a directory with a module path prefix turned to dirs it would effectively try to trim the module name prefixes this PR is adding support for.
3 participants
Adds support for specifying the module name + module prefix for pyo3 extensions.