Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial revert of #3704. It does NOT revert logic that properly finds the hermetic archiver (binary and associated tests).
cc-rs needs full ownership of flag handling for the archiver. This is in part due to
arhaving very specific positional flag behaviors, and partially due to some special logic in how cc-rs constructs static libraries.The change to enable
ARFLAGSwas causing many toolchains that pass flags to the static archiver to error out due to conflicting expectations for flag handling. Example badarinvocation, wherecqis treated as the destination archive instead of theartool mode:This drops forwarding of
ARFLAGSto fix the common case.