Drop additional_rpaths toolchain logic - #1851
Closed
keith wants to merge 1 commit into
Closed
Conversation
These rpaths never seem to be valid for hermetic toolchains
keith
marked this pull request as ready for review
July 10, 2026 17:49
keith
requested review from
aaronsky,
adincebic,
brentleyjones and
luispadron
as code owners
July 10, 2026 17:49
keith
enabled auto-merge (squash)
July 10, 2026 17:50
keith
disabled auto-merge
July 10, 2026 17:54
Member
Author
|
trying to verify we're not missing some case here, but these rpaths just seem invalid |
Member
Author
|
this does matter, currently binaries don't use this but tests do. im looking into a wider version of this fix in #1853 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These rpaths never seem to be valid for hermetic toolchains. The macOS hermetic
toolchain doesn't work at all right now. I think to fix that we'll need to let bazel
handle these with cc_imports or something instead.