Repository navigation
pre-commit: add bridgelint hook - #307
Merged
Merged
Conversation
Contributor
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs bridgelint as a pre-commit hook, so the existing lint job checks bridgev2 error reporting (message statuses, login and provisioning RespErrors, direct media errors and bridge states) on every push. Only error-severity findings fail the job, and
verbose: trueprints warnings on passing runs too.Change
beeper/pre-commit-gofrom v0.4.2 to v0.5.0 and enable thebridgelinthook. Line endings in.pre-commit-config.yamlare kept as CRLF.Current findings
On
main, bridgelint reports no errors and 2 warnings, so the lint job passes and prints the warnings. bridgelint coverspkg/ltsmtoo, unlike the localgo vethook, so the first run is slower.Tag
@indentto continue the conversation here.