Skip to content

[upstream #16875] Pin combined brand override precedence in the cache output #297

Description

@berry-13

The resolver output pin in client/src/Providers/__tests__/themeCache.spec.ts generates one fixture per role and scope (theme-wide, light only, dark only), each overriding a single role. A definition that sets the same brand token theme-wide and per mode is not covered, so a precedence regression between the two would leave the pinned digest unchanged.

Fix direction: add a fixture per brand token with conflicting theme-wide, light and dark values, and check each persisted mode.

Activity

  1. added
    testreviewctl followups state
    area: clientreviewctl followups state
    readyreviewctl followups state
    and removed on Oct 7, 2026
  2. berry-13 commented on Oct 8, 2026

    @berry-13
    OwnerAuthor

    Fixed by LibreChat-AI#16875 before merge: client/src/Providers/tests/themeCache.spec.ts:334-342 adds a brand::conflict fixture with conflicting theme-wide, light and dark values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups statereadyreviewctl followups statetestreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions