Update Factory Stop Que behavior#7858
Closed
26Projects wants to merge 3 commits into
Closed
Conversation
Collaborator
|
This is reversed of the standard behaviour in which: Repeat - alt inserts after the current unit |
Author
|
Repeat on + current build is options.internal: Because it stays internal, FactoryCAI::DecreaseQueueCount() treats it like a one-shot priority/current build, so it should not keep repeating after completion. Repeat off, or repeat on but first command is not internal: That matches the intended “finish current unit, then stop” behavior for repeat factories while preserving normal non-repeat cancellation behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Factory Stop Que behavior
Work done
Updated factory stop-production queue clearing so factories/labs on repeat fully clear their production queue.
Previously, the stop-production command preserved one copy of the currently building unit whenever the queue had more than one item. That behavior is still useful for manual production mode, where it avoids accidentally cancelling the current unit. However, on repeat mode, preserving one item means the factory can continue producing after the player expected the queue to be cleared.
This change checks the factory repeat state before preserving the current build order:
Manual mode: keeps the existing “leave current unit” behavior.
Repeat mode: removes all queued build orders, including the current repeated item.
Addresses Issue(s)
https://discord.com/channels/549281623154229250/1508850740473368748
Test steps
In game testing on local dev
AI / LLM usage statement:
Developed with Codex