spectator hud: add separate stats for land, air and naval army

[NeYurii]

Work done

In advanced spectator hud add separate metrics for land, air and naval army value.
Reason: there can be a lot of army value in ships or fighters, and with single metric it is hard to estimate real land army size.

Spanish and Chinese translation made with translator so possibly contains some errors.

Screenshots:

BEFORE:

AFTER:

[WatchTheFort]

This widget is already a UX nightmare, we should be improving the UX, not exacerbating the problem.

[Azzurite]

When I started watching this game, I was impressed with this spectator interface. The literal only "UX" problem I see is that when you see it on a stream/video, you can't hover over it to get tooltips, and thus it is hard to know what the abbreviations stand for.

I think this is a great addition to it :)

@WatchTheFort What do you think is the UX problem with this spectator interface, and how would you improve it?

[Azzurite]

There is an optimization opportunity here, theoretically it is possible to completely remove the unitCache[..].armyUnits, cachedTotals[..].armyUnits and unitDefsToTrack.armyUnitDefs.

Instead, you can just have getOneStat return the sum cachedTotals[teamID].landArmyUnits + cachedTotals[teamID].airArmyUnits + cachedTotals[teamID].navalArmyUnits for the metricKeys.armyValue case.

[WatchTheFort]

@WatchTheFort What do you think is the UX problem with this spectator interface, and how would you improve it?

You only know what the letters mean if you already know what the letters mean. A UI packed full of abbreviations and short forms is bad design, in any software.

[Azzurite]

A UI packed full of abbreviations and short forms is bad design

You have kind of a point, however, I think your statement should be "is bad design for new users". As soon as you know what the abbreviations mean, they actually become good design, because it saves screen space, allowing you to see more of the action, while still identifying it clearly.

I know specialist software from my jobs that simply could not display everything on their screens if they didn't use abbreviations. Or look at pilot cockpits or the Apollo instruments. These interfaces are all perfectly clear to the ones trained on them and allow them to find the right information quickly.

I know from myself that I am perfectly fine spectating BAR matches with this interface. You can make the argument that the default should be something like

    Metal per Second
[=====<200%>===========]

  Total Metal Produced
[========<60%>=========]

   Army Value in Metal
[=========<0%>=========]

with an option to change to the abbreviations. But abbreviations are still a fine thing in some cases, which includes this one.

[Azzurite]

(and anyway, I don't think this point is very relevant to this particular PR, there are already a lot of these bars and abbreviations, adding these ones does not make it particularly worse)

[NeYurii]

There is an optimization opportunity here, theoretically it is possible to completely remove the unitCache[..].armyUnits, cachedTotals[..].armyUnits and unitDefsToTrack.armyUnitDefs.

Instead, you can just have getOneStat return the sum cachedTotals[teamID].landArmyUnits + cachedTotals[teamID].airArmyUnits + cachedTotals[teamID].navalArmyUnits for the metricKeys.armyValue case.

Applied this changes.

This widget is already a UX nightmare, we should be improving the UX, not exacerbating the problem.

Maybe. But i can not imagine other ways to change it then make entirely new widget or move it to separate window (like in starcraft or something like). Even if at one point it will be changed, this still can be useful while we still dealing with this widget.
This change was asked by one tourney player, so i think it could be useful for many people.

[sprunk]

A UI packed full of abbreviations and short forms is bad design

You have kind of a point, however, I think your statement should be "is bad design for new users"

BAR's target audience is autists who love complexity, so adding a bunch of obscure sliders is actually excellent for attracting new users.

[Azzurite]

Just tested it in game, and in the options for spectator hud mode "custom":

The entries for the different new army values are missing.

The definition can be found in gui_options line 5001.

[NeYurii]

Just tested it in game, and in the options for spectator hud mode "custom":

The entries for the different new army values are missing.

The definition can be found in gui_options line 5001.

Fixed this.
Would not it be better if options were added by each widget? I saw there addOption, but apparently it is only for custom widgets.

[Azzurite]

Would not it be better if options were added by each widget?

Definitely. I don't know anything about this part of the code. In my uneducated opinion, the optimal implementation would be to have the option widget call a function in the spectator HUD widget, which returns the definitions of all available options. The option widget would then only be responsible for rendering them and putting these options in the appropriate location. The spectator HUD widget can not know where to exactly put them.

It would be a very worthwhile refactoring, good idea!

[Azzurite]

Nice addition :)

[WatchTheFort]

@icexuick Can we please get a UX design overhaul for this widget? It is extremely unfriendly.

[icexuick]

@icexuick Can we please get a UX design overhaul for this widget? It is extremely unfriendly.

Yes, this will be added to the new UI rework.
For the time being, we might leave it be, even though I agree with all the letters/abbreviations being very poor/bad.