Set Target: remove crashing, dead, object, critter, and fake units#7935
Draft
efrec wants to merge 3 commits into
Draft
Set Target: remove crashing, dead, object, critter, and fake units#7935efrec wants to merge 3 commits into
efrec wants to merge 3 commits into
Conversation
added 2 commits
June 11, 2026 11:42
This is slightly hack but is reliable at the moment. UnitNoSelect is our most general term for "this unit is not part of gameplay" so it works here. We also fix the unit alwaysSeen check and add a guard/reset around it.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Removes units from targeting that have become non-interactive: dead or dying, crashing, objects, critters, and fake/paired units (Printer, Fortifier).
Some units are not selectable but are still part of gameplay interaction: drones, some dead/dying units, in-progress unit upgrades.
Drafted until I can test and probably until I can be bothered to handle the NoSelect shims/utils as more distinct cases. I don't think we need a mini-api for this but it would at least make explicit what we have implicitly lying around in code.