Skip to content

Pause target lists on CMD_WAIT and handle longterm pause#7955

Merged
WatchTheFort merged 5 commits into
beyond-all-reason:masterfrom
efrec:set-target/pause-target-list-on-wait
Jun 24, 2026
Merged

Pause target lists on CMD_WAIT and handle longterm pause#7955
WatchTheFort merged 5 commits into
beyond-all-reason:masterfrom
efrec:set-target/pause-target-list-on-wait

Conversation

@efrec

@efrec efrec commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Work done

Pause target lists on CMD_WAIT.

Before:

  • Paused lists were handled as a temporary condition when it they applied only to DGuns. They now apply to Attack commands, with some exceptions, also.
  • We wanted stable visuals across a fast pause/unpause. The target index and active/passive target status were kept the same during pause, and unsynced was given fallbacks to handle any disagreements.

After:

  • We reach a clear breakpoint with pause-on-wait, which is indefinite.
  • We work toward consistency between sync/unsync at all times rather than betting on the pause being intermittent.

Could use more handiwork on this, but I kept it simple since the discrepancy here is small. I feel like I am breaking someone's spacebar heater, also.

efrec added 2 commits June 14, 2026 10:46
So don't pretend that we are still targeting during pause.

This was useful for the short time period that a Commander might be DGunning to prevent the appearance of the target list updating needlessly.

Now, I'm not so sure. This could use a touch-up overall and I am not nearly convinced that this change accomplishes that above the minimum level. Pushing onward. Rocket emoji.
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

15 tests   - 1   6 ✅  - 2   3s ⏱️ -1s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   1 ❌ +1 

For more details on these failures, see this check.

Results for commit f4b4195. ± Comparison against base commit 96d4758.

This pull request removes 1 test.
ai_stai_factory_rect.lua

♻️ This comment has been updated with latest results.

@efrec efrec marked this pull request as ready for review June 14, 2026 18:04
@WatchTheFort WatchTheFort merged commit 57967b7 into beyond-all-reason:master Jun 24, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants