Skip to content

sharing 2/4: transfer runtime (controllers, economy boundary, gadget swap)#7963

Merged
keithharvey merged 1 commit into
sharing_tab_mergeablefrom
sharing/02-transfer-runtime
Jun 22, 2026
Merged

sharing 2/4: transfer runtime (controllers, economy boundary, gadget swap)#7963
keithharvey merged 1 commit into
sharing_tab_mergeablefrom
sharing/02-transfer-runtime

Conversation

@keithharvey

@keithharvey keithharvey commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

📚 Stacked split of #5704 — review bottom-up

Each PR merges into the one below it; all four squash-equal the sharing_tab branch (verified byte-identical).


Stack 2 of 4 splitting #5704. Builds on 1/4.

The behavior switch. Replaces the old sharing/restriction gadgets with two unified controllers and routes all team-resource reads/writes through the GG economy boundary.

  • add game_resource_transfer_controller (defines GG.GetTeamResources/AddTeamResource/SetTeamShareLevel) and game_unit_transfer_controller
  • add cmd_take, allied unit reclaim / partial resurrection / ally geo-mex modes; rename game_disable_assist_allygame_allied_assist_mode
  • delete game_tax_resource_sharing, game_no_share_to_enemy, game_prevent_excessive_share, game_restrict_unit_sharing, game_disable_unit_sharing, game_restrict_resurrection
  • migrate all Spring.*TeamResource* call sites to the GG.* boundary
  • gadgets/modrules registration, controller spec, in-game test widgets

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Integration Test Results

18 tests  +3   7 ✅ ±0   6s ⏱️ +2s
 1 suites ±0   8 💤 ±0 
 1 files   ±0   3 ❌ +3 

For more details on these failures, see this check.

Results for commit 7f9a08f. ± Comparison against base commit 4c65388.

♻️ This comment has been updated with latest results.

@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 3 times, most recently from 422d6fb to cd8b830 Compare June 16, 2026 22:37
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 64f3fb5 to 8c607b5 Compare June 16, 2026 22:37
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 2 times, most recently from dc78397 to eeae38a Compare June 18, 2026 10:02
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 495e115 to af8b189 Compare June 18, 2026 20:10
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 3 times, most recently from 5fb30d4 to 3eb596e Compare June 19, 2026 07:54
@keithharvey keithharvey mentioned this pull request Jun 19, 2026
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch 3 times, most recently from d2cb412 to 838f636 Compare June 19, 2026 22:06
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 1ac1893 to 20801f9 Compare June 19, 2026 22:06
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 1b93e8f to 7f9a08f Compare June 20, 2026 05:31
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 20801f9 to 4c65388 Compare June 20, 2026 05:31
@keithharvey keithharvey force-pushed the sharing/01-foundations branch from 4c65388 to fc1c4e1 Compare June 22, 2026 06:37
@keithharvey keithharvey force-pushed the sharing/02-transfer-runtime branch from 7f9a08f to d9f2d4a Compare June 22, 2026 06:37
Base automatically changed from sharing/01-foundations to sharing_tab_mergeable June 22, 2026 06:37
@keithharvey keithharvey merged commit d9f2d4a into sharing_tab_mergeable Jun 22, 2026
@keithharvey keithharvey deleted the sharing/02-transfer-runtime branch June 22, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant