FactoryQ Manager: contextual load hotkeys + toggle action (v1.7)#8047
Open
MadeByGabe wants to merge 1 commit into
Open
FactoryQ Manager: contextual load hotkeys + toggle action (v1.7)#8047MadeByGabe wants to merge 1 commit into
MadeByGabe wants to merge 1 commit into
Conversation
Adds `factory_preset_toggle` action. If that action is used, then preset load actions only fire and consume the keypress while the preset panel is open. In practice this means that a preset load which was triggered by `space+1` before, now only triggers on `space, space+1` (the first space is to open the preset panel, the second to load a preset). `factory_preset_show` behavior is unchanged. This frees the Meta+[0-9] binds for other widgets when the preset panel is closed. This is needed so Squad Selection can reuse them for group selection.
Contributor
Integration Test Results15 tests ±0 6 ✅ ±0 3s ⏱️ ±0s For more details on these failures, see this check. Results for commit 9694dc9. ± Comparison against base commit f1d591f. |
Contributor
|
I'm wondering, do you even need this toggle? You can change the actions so they pass the inputs forward instead of consuming them |
Contributor
Author
|
Replacing my factory queue by loading a preset when I just want to select my group isn't optimal. So in my opinion this toggle is needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work done
Adds
factory_preset_toggleaction.If that action is used, then preset load actions only fire and consume the keypress while the preset panel is open. In practice this means that a preset load which was triggered by
space+1before, now only triggers onspace, space+1(the first space is to open the preset panel, the second to load a preset).The
factory_preset_showbehavior is unchanged except that too consumes the keypress.factory_preset_showcan just be replaced withfactory_preset_toggleif desired.Using
factory_preset_togglefrees up thespace+[0-9]keybinds for other uses while still allowing the factory preset load actions to be used with the same keybinds, but only while the preset panel is open.Test steps
space+alt+1space+1to make sure it still worksbind any+sc_space factory_preset_showtobind any+sc_space factory_preset_togglespace+1and make sure it doesn't work anymore (the bind passes through)spaceand then load the preset withspace+1to make sure it works.AI / LLM usage statement:
I wrote the state machine, Claude Code implemented the corresponding branch logic.