feat: add new NETMSG_DEDIMSG for private comms to game server#2957
feat: add new NETMSG_DEDIMSG for private comms to game server#2957bruno-dasilva wants to merge 1 commit into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| NETMSG_PING = 78, // uint8_t playerNum, uint8_t pingTag, float localTime | ||
|
|
||
| NETMSG_DEDIMSG = 79, // /* uint16_t messageSize */, uint8_t playerNum, uint16_t header, std::vector<uint8_t> payload | ||
|
|
There was a problem hiding this comment.
im sure there is a better name than dedimsg... but im ironing out use cases right now. open to suggestions
bruno-dasilva
force-pushed
the
bruno/stats-api-1
branch
from
81b7601 to
e44ce37
Compare
bruno-dasilva
force-pushed
the
bruno/stats-api-1
branch
from
e44ce37 to
739058d
Compare
| *packet << static_cast<uint16_t>(packetSize) << playerNum << header << payload; | ||
| return PacketType(packet); | ||
| } | ||
|
|
There was a problem hiding this comment.
xref #2712 (comment)
a universal "freestyle data" packet with a bunch of specifiable traits (whether to leave replay trace, which players or network clients to send to, which "internal" destination eg Lua env, etc), and that LUAMSG is already such relatively universal packet to some extent (with script and mode being ways to choose from a bunch of bundles of traits). I don't know, it sounds reasonable actually but somehow not right, though I can't quite put my finger on it.
This is a possible, more flexible but more complex alternative implementation. LMK what you think.
|
Looks directionally correct. The name should probably be something along the lines of "secret host message" since this isn't specific to dedi. |
| * record-type header. The header is engine-encoded little-endian and must be | ||
| * in the game-private range 0x1000..0xFFFF; values below 0x1000 are reserved | ||
| * for engine use. |
There was a problem hiding this comment.
what does the header do? what do its numerical values mean? why does the engine reserve 0-4095?
| NETMSG_PING = 78, // uint8_t playerNum, uint8_t pingTag, float localTime | ||
|
|
||
| NETMSG_DEDIMSG = 79, // /* uint16_t messageSize */, uint8_t playerNum, uint16_t header, std::vector<uint8_t> payload | ||
|
|
| if (playerNum != a) { | ||
| Message(spring::format(WrongPlayer, msgCode, a, (unsigned)playerNum)); | ||
| break; | ||
| } |
| throw netcode::PackPacketException("[BaseNetProto::SendDediMsg] maximum packet-size exceeded"); | ||
|
|
||
| PackPacket* packet = new PackPacket(packetSize, NETMSG_DEDIMSG); | ||
| *packet << static_cast<uint16_t>(packetSize) << playerNum << header << payload; |
There was a problem hiding this comment.
putting packetSize into the packet is probably redundant
2 participants
First PR: game packet #2040
Second PR: hook up to autohost #2040
Third PR: usage of game packets with a small engine stats api, local file #2041
Fourth PR: send default engine stats through this API