Implemented GetUnitFactoryBuilding() method#2995
Open
PexoDev wants to merge 2 commits into
Open
Conversation
PexoDev
commented
May 31, 2026
sprunk
reviewed
Jun 1, 2026
sprunk
left a comment
sprunk
left a comment
Collaborator
There was a problem hiding this comment.
Looks technically correct but polling all units to check if they're the factory is going to be relatively expensive. Would be ideal if buildees had a pointer to the fac.
Author
|
I understand, makes sense. |
sprunk
reviewed
Jun 8, 2026
|
|
||
| if (unit->producingFactory == nullptr) | ||
| return 0; | ||
|
|
Collaborator
There was a problem hiding this comment.
should probably also return if !LuaUtils::IsUnitInLos(L, unit->producingFactory) at this point
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #2892 - added a new method to fetch factory's ID of given unit being build.
As discussed in the issue's thread - this covers factories exclusively and doesn't account for mobile builders.