Fix WebUI validation adapter config file paths - #3211
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebUI configuration normalization converted existing validation adapter JSON files under the configured directory into relative paths. Unlike the other JSON configuration fields,
validation_adapter_configwas missing from the fields resolved back to absolute paths. Training could therefore no longer load the file and raised the misleading "must be a list or a dict containing 'runs'" error, while inline JSON worked.Include validation adapter configs in the existing JSON path handling. Regression coverage follows WebUI normalization, configuration serialization/loading, and adapter run construction for a single adapter object, an array, and a
runsobject. Absolute and relative paths match inline JSON; files outside the config directory still work and malformed inputs still fail.Validation: the existing absolute-file regression reproduced the reported error before the fix. All 54 tests pass with
.venv/bin/python -m unittest -v -f tests.test_validation_adapter_config tests.test_validation_adapters tests.test_configs_service_environment tests.test_training_service. Black and isort checks pass for both changed files.Closes #3205.