Refresh training reports before post-upload scripts - #3214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static report embeds a snapshot refreshed every 100 metric records. Post-upload scripts could therefore copy an HTML report from step 943 even after metrics and validation images for checkpoint 1000 had been written.
Refresh the enabled local report before submitting an external hook. This reuses the shared path used by trainer uploads, validation publishing, and checkpoint hooks, so the report includes the latest recorded metrics, validation media, and timestep samples. Serialize report renders to prevent periodic and background upload refreshes from sharing a temporary file or overwriting a newer snapshot with an older one. Runs without the local tracker do not create reports.
Validation:
.venv/bin/python -m unittest -v -f tests.test_script_runner tests.test_local_metricspassed all 14 tests..venv/bin/python -m unittest -v -f tests.test_trainer tests.test_validation_external tests.test_training_metrics_service tests.test_training_metrics_routespassed all 132 tests.git diff --cached --checkpassed.Closes #3207.