Fix checkpoint navigation in static training reports - #3216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The static
training_report.htmllightbox only exposed image navigation, so validation outputs could not be compared across checkpoints while enlarged. Reuse the report's step timeline in the lightbox, preserve the same output by label and index when changing steps, and support Up/Down for checkpoints alongside Left/Right for samples. Only checkpoints containing that output are offered, matching the normal WebUI.The gallery's checkpoint row now stays visible while scrolling. Step controls have larger touch targets, and long timelines keep the selected checkpoint horizontally visible without scrolling the page.
Validation: reproduced the original missing controls, inactive Up key, and scrolling timeline in three failing Selenium tests before implementation; a separate long-timeline regression also failed before its fix. All 15 tests now pass, including six real-Chrome browser tests with mobile viewport and touch emulation:
SIMPLETUNER_SELENIUM_TESTS=1 .venv/bin/python -m unittest -v tests.test_training_report_e2e tests.test_local_metricsCoverage includes missing outputs, first/last sample boundaries, empty and single-step reports, fit/actual-size controls, gallery synchronization, and long checkpoint lists. Mobile behavior was verified with Chrome emulation, not physical Android hardware.
Fixes #3200.