Add Continue for failed local jobs and show project/run names - #3219
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failed local jobs now offer Continue, which selects their saved configuration and invokes the existing Run flow with its configured checkpoint resume setting. Configuration activation or loading failures stop the action before training starts. Click and keyboard events stay within the Continue button.
Job cards and search now use project / run names, including tracker metadata already stored in local job history. Cloud submissions persist project identity alongside the run name.
Closes #3204.
Validation:
npm test -- --runInBand tests/js/cloud_utilities.test.js tests/js/cloud_jobs.test.js tests/js/job_submission.test.js: 133 passed..venv/bin/python -m unittest -v tests.test_cloud_job_tracker_metadata tests.test_training_service tests.test_training_service_gpu: 63 passed.SIMPLETUNER_SELENIUM_TESTS=1 .venv/bin/python -m unittest -v tests.test_webui_e2e.FailedLocalJobContinueTestCase tests.test_webui_e2e.EasyModeFormDirtyTestCase.test_easy_mode_select_enables_save: 4 passed in Chrome. Covers the saved checkpoint request, activation failure, config loading failure, and click/keyboard propagation.Browser tests inspect the existing Run request without launching model training. Continue preserves the saved resume setting; it does not add checkpoint compatibility or recovery behavior.