Add context to bgpkit warning messages#274
Merged
digizeph merged 4 commits intobgpkit:mainfrom Mar 31, 2026
Merged
Conversation
When reading logs, lines like ``` WARN worker-13 mrt_file: not enough bytes: input bytes left - 3, want to read - 1024; skipping ^]]3mfile=./2025-11-05/rrc00/2025.11/updates.20251105.0600.gz WARN worker-26 mrt_file: not enough bytes: input bytes left - 3, want to read - 1024; skipping ^]]3mfile=./2025-11-05/rrc15/2025.11/updates.20251105.0605.gz ``` Made me think the full file was skipped, while only the attributes for this message were skipped. I think adding context to the warning messages clarifies them.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 84 84
Lines 15496 15496
=======================================
Hits 14056 14056
Misses 1440 1440 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading logs, lines like
Made me think the full file was skipped, while only the attributes for this message were skipped.
I think adding context to the warning messages clarifies them.