Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Tobias @tpietzsch,
I've looked into the rendering of those border "half pixels" again.
Here is an example (code) comparing two 5x5x5 volumes side-by-side:
"simple" RAI on the left and "multires" on the right (shifted by 5 pixels in X).
They are not identical. The reason is that in the "simple" and "multires" intersection box is calculated as:
For the source from 0 to N-1 it would span [0; N-1], but it should be [-0.5, N-0.5].
This is the reason why single plane (or just 2D) images are not currently displayed in BVV.
Correcting this for all sampling shaders
gives:

So either there is no zero padding from (0,0,0), or texture reading in the shader is wrong.
Looking at this code, I think the padding is ok (paddOffset is subtracted from min).
Now, fixing the multires sampling shader finally gives:
Cheers,
Eugene
p.s. Working on this, I've noticed the Multibox sources view is not correct, so I've submitted another PR.