Conversation
Bugs: - for some reason this selects internal nodes sometimes? even though it should be filtering to leaves. not sure. - menu isn't positioned correctly (at barplot) - menu doesn't show up until tree is zoomed or panned, implying that the drawtree call somehow isn't working
gotta fix positioning but past that should be ok
Doesn't work well with zooming/panning/etc tho yet. We _should_ modify the selected node menu class so that updateMenuPosition() is only called after a node has already been selected, I guess...? Or, like, rather than following a node's position, it now follows the barplot's position. Or the node's position at some barplot displacement. IDK.
Remaining TODOs: - Fix schmoovement of node selection menu when zooming/panning after clicking on barplots -- rather than "anchoring" the menu to a node's position in tree space we should anchor it to a barplot (or really just the coordinate clicked)'s position. hm. Not sure how best to do that; will likely require some decent refactoring. - Fix the way barplot clicks are mapped to tips. Right now it's possible to click outside of a tip's half-angle range (i.e. clicking visibly on another bar) and another tip will get selected. I think it might be best to address this by just checking which tip's "half angle range" the click falls in? not sure how best to do that tho.
|
The following artifacts were built for this PR: empire-biplot.qzv, empire.qzv, empress-tree.qzv, just-fm.qzv, plain.qzv |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't done yet -- there are still some major issues that need to be fixed (see #308) before merging this in. However, I wanted to set up this PR so that this prototype can be easily tested out, at least.
cc @ElDeveloper