Skip to content

Learners should not hold references to widgets #9

Open

Description

@astaric

When learners are used with Tests & Score widget, they get deep_copied, which is implemented in python as pickling and unpickling. If a learner holds a reference to a widget, this currently results in a crash, as widgets cannot be pickled. But even if they could be, this would result in an unexpected behaviour where we would end up with two instances of the same widget, but only one node on a canvas.

See biolab/orange3#2793

Activity

  1. bernardofn commented on Apr 18, 2018

    @bernardofn

    Any idea when this will be solved?

  2. astaric commented on Apr 19, 2018

    @astaric
    MemberAuthor

    Sadly, no.

    This add-on has been developed as a GSoC 2016 project but has not been maintained since. If you want, you can take a look at the code base and try to submit a pull request to fix the problem.

    The simplest fix would be to constructs learners in widgets without callbacks, avoiding the problem alltogether.

  3. bernardofn commented on Apr 19, 2018

    @bernardofn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions