Skip to content

Fix currency conversion data finding error #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btrdnch merged 4 commits into from
Jun 4, 2026
Merged

Fix currency conversion data finding error #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e26bbea
Merge pull request #515 from bitfinexcom/staging
btrdnch May 18, 2026
46596f1
Add ability to log metadata for CurrencyConversionDataFindingError
ZIMkaRU May 26, 2026
069fcb1
Log symbol and mts for CurrencyConversionDataFindingError
ZIMkaRU May 26, 2026
43cce70
Enhance getting ccy pair for currency conversion
ZIMkaRU May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions workers/loc.api/errors/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ class ObjectMappingError extends BaseError {
}

class CurrencyConversionDataFindingError extends BaseError {
constructor (message = 'ERR_DATA_IS_NOT_FOUND_TO_CONVERT_CURRENCY') {
super(message)
constructor (data, message = 'ERR_DATA_IS_NOT_FOUND_TO_CONVERT_CURRENCY') {
super({ data, message })
}
}

Expand Down
24 changes: 18 additions & 6 deletions workers/loc.api/sync/currency.converter/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,17 +348,25 @@ class CurrencyConverter {
if (typeof symbol !== 'string') {
return ''
}
if (symbol.length < 8) {
if (symbol.length < 6) {
return symbol
}

const hasFlag = (
symbol.startsWith('t') ||
symbol.startsWith('f')
)
const flag = hasFlag
? symbol[0]
: 't'

if (
symbol[0] !== 't' &&
symbol[0] !== 'f'
symbol.length === 7 &&
hasFlag
) {
return symbol
}

const flag = symbol[0]
const [firstSymb, lastSymb] = splitSymbolPairs(symbol)
const _firstSymb = this._getConvertingSymb(firstSymb)
const _lastSymb = this._getConvertingSymb(lastSymb)
Expand Down Expand Up @@ -1031,7 +1039,9 @@ class CurrencyConverter {
)

if (!Number.isFinite(price)) {
throw new CurrencyConversionDataFindingError()
throw new CurrencyConversionDataFindingError(
{ symbol: reqSymb, mts }
)
}

return price
Expand Down Expand Up @@ -1082,7 +1092,9 @@ class CurrencyConverter {
)
}

throw new CurrencyConversionDataFindingError()
throw new CurrencyConversionDataFindingError(
{ symbol: reqSymb, mts: end }
)
}

async convertManyByCandles (data, convSchema) {
Expand Down