Skip to content

Conversation

@SaintPatrck
Copy link
Contributor

@SaintPatrck SaintPatrck commented Dec 15, 2025

🎟️ Tracking

PM-29842
Relates to bitwarden/server#6721

📔 Objective

Introduce new organization event types to track user decisions regarding the migration of personal ciphers to an organization's "My Items" folder, typically triggered by personal vault ownership policies.

Actual event tracking will be implemented in a subsequent PR.

Specific changes:

  • Update OrganizationEventType in the network layer to include ORGANIZATION_ITEM_ORGANIZATION_ACCEPTED (1618) and ORGANIZATION_ITEM_ORGANIZATION_DECLINED (1619).
  • Add corresponding data objects ItemOrganizationAccepted and ItemOrganizationDeclined to the OrganizationEvent sealed class hierarchy to handle these events within the application logic.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

… and rejection

This commit introduces new organization event types to track user decisions regarding the migration of personal ciphers to an organization's "My Items" folder, typically triggered by personal vault ownership policies.

Specific changes:
- Update `OrganizationEventType` in the network layer to include `ORGANIZATION_ITEM_ORGANIZATION_ACCEPTED` (1618) and `ORGANIZATION_ITEM_ORGANIZATION_DECLINED` (1619).
- Add corresponding data objects `ItemOrganizationAccepted` and `ItemOrganizationDeclined` to the `OrganizationEvent` sealed class hierarchy to handle these events within the application logic.
@claude
Copy link
Contributor

claude bot commented Dec 15, 2025

Claude finished @SaintPatrck's task in 2m 24s —— View job


Code Review Complete ✓

The review has been completed. All findings have been posted as inline comments and a summary review.

Status: Changes look good - the implementation correctly follows Bitwarden's established patterns for organization event types.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa7c6e4a2-6fc8-4697-98ad-58047b04e569

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck changed the title [PM-28472] Add organization event types for item migration acceptance and rejection [PM-29842] Add organization event types for item migration acceptance and rejection Dec 16, 2025
@codecov
Copy link

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.53%. Comparing base (d09945d) to head (15ac0cf).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6273   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files         761      761           
  Lines       54519    54519           
  Branches     7833     7833           
=======================================
  Hits        46633    46633           
  Misses       5169     5169           
  Partials     2717     2717           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck added this pull request to the merge queue Dec 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2025
@david-livefront david-livefront added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit 7c929c3 Dec 16, 2025
18 of 19 checks passed
@david-livefront david-livefront deleted the PM-28472/org-event-types branch December 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants