Skip to content

[PM-29219] enforce small drawer size for Access Intelligence #17915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexRubik wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −3
Open

[PM-29219] enforce small drawer size for Access Intelligence #17915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions bitwarden_license/bit-common/src/dirt/reports/risk-insights/models/drawer-models.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ export type DrawerDetails = {
open: boolean;
invokerId: string;
activeDrawerType: DrawerType;
/**
* Explicit drawer width variant. Default to "small" to preserve current layout.
*/
size?: "small" | "default" | "large";
atRiskMemberDetails?: AtRiskMemberDetail[];
appAtRiskMembers?: AppAtRiskMembersDialogParams | null;
atRiskAppDetails?: AtRiskApplicationDetail[] | null;
Expand Down
7 changes: 7 additions & 0 deletions ...nse/bit-common/src/dirt/reports/risk-insights/services/view/risk-insights-data.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ export class RiskInsightsDataService {
open: false,
invokerId: "",
activeDrawerType: DrawerType.None,
size: "small",
atRiskMemberDetails: [],
appAtRiskMembers: null,
atRiskAppDetails: null,
Expand Down Expand Up @@ -112,6 +113,7 @@ export class RiskInsightsDataService {
open: false,
invokerId: "",
activeDrawerType: DrawerType.None,
size: "small",
atRiskMemberDetails: [],
appAtRiskMembers: null,
atRiskAppDetails: null,
Expand All @@ -137,6 +139,7 @@ export class RiskInsightsDataService {
open: true,
invokerId,
activeDrawerType: DrawerType.OrgAtRiskMembers,
size: "small",
atRiskMemberDetails,
appAtRiskMembers: null,
atRiskAppDetails: null,
Expand Down Expand Up @@ -167,6 +170,7 @@ export class RiskInsightsDataService {
open: true,
invokerId,
activeDrawerType: DrawerType.AppAtRiskMembers,
size: "small",
atRiskMemberDetails: [],
appAtRiskMembers: atRiskMembers,
atRiskAppDetails: null,
Expand All @@ -192,6 +196,7 @@ export class RiskInsightsDataService {
open: true,
invokerId,
activeDrawerType: DrawerType.OrgAtRiskApps,
size: "small",
atRiskMemberDetails: [],
appAtRiskMembers: null,
atRiskAppDetails,
Expand Down Expand Up @@ -219,6 +224,7 @@ export class RiskInsightsDataService {
open: true,
invokerId,
activeDrawerType: DrawerType.OrgAtRiskMembers,
size: "small",
atRiskMemberDetails,
appAtRiskMembers: null,
atRiskAppDetails: null,
Expand Down Expand Up @@ -251,6 +257,7 @@ export class RiskInsightsDataService {
open: true,
invokerId,
activeDrawerType: DrawerType.OrgAtRiskApps,
size: "small",
atRiskMemberDetails: [],
appAtRiskMembers: null,
atRiskAppDetails: criticalAtRiskApps,
Expand Down
6 changes: 3 additions & 3 deletions ...it-web/src/app/dirt/access-intelligence/shared/risk-insights-drawer-dialog.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@if (isActiveDrawerType(drawerTypes.OrgAtRiskMembers)) {
<bit-dialog dialogSize="large" disablePadding="false">
<bit-dialog [dialogSize]="drawerDetails.size ?? 'small'" disablePadding="false">
<ng-container bitDialogTitle>
<span>{{
"atRiskMembersWithCount" | i18n: drawerDetails.atRiskMemberDetails?.length ?? 0
Expand Down Expand Up @@ -45,7 +45,7 @@
}

@if (isActiveDrawerType(drawerTypes.AppAtRiskMembers)) {
<bit-dialog dialogSize="large" disablePadding="false">
<bit-dialog [dialogSize]="drawerDetails.size ?? 'small'" disablePadding="false">
<ng-container bitDialogTitle>
<span>{{ drawerDetails.appAtRiskMembers?.applicationName }}</span>
</ng-container>
Expand All @@ -71,7 +71,7 @@
}

@if (isActiveDrawerType(drawerTypes.OrgAtRiskApps)) {
<bit-dialog dialogSize="large" disablePadding="false">
<bit-dialog [dialogSize]="drawerDetails.size ?? 'small'" disablePadding="false">
<ng-container bitDialogTitle>
<span>{{
"atRiskApplicationsWithCount" | i18n: drawerDetails.atRiskAppDetails?.length ?? 0
Expand Down
Loading