[PM 29079]Remove code for pm-24033-updat-premium-subscription-page

[cyprain-okeke]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29079

📔 Objective

Remove the indicated feature flag, using the steps defined here.

Each of the tasks is labeled with the corresponding step from the documentation.

📸 Screenshots

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[claude]

Claude finished @cyprain-okeke's task in 2m 39s —— View job

---

Code Review Complete ✓

Overall Assessment: APPROVE

This PR cleanly removes the feature flag pm-24033-updat-premium-subscription-page from the codebase.

Verified

• Feature flag constant removed from src/Core/Constants.cs:195
• No remaining references to the flag in the codebase
• No orphaned code requiring cleanup
• Historical usage confirmed (flag was only a constant declaration, never used in server-side conditionals)

Findings

The removal is complete and correct. The feature flag PremiumUpgradeNewDesign was only declared as a constant for client-side consumption and was never used in any server-side conditional logic, so no additional code cleanup is needed.

[github-actions]

Checkmarx One – Scan Summary & Details – bbd73d0a-503b-4c88-8019-5a9938586b3c

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Path_Traversal	/src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs: 56	details Method at line 56 of /src/Api/Controllers/SelfHosted/SelfHostedOrganizationLicensesController.cs gets dynamic data from the model element. This ... ID: HwphbdG3YaZTdiMdREyc8GsPw%2Bw%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1519	details Method at line 1519 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: dMGF5qNfAN72zlvQcA1MgbhHv%2Fc%3D Attack Vector
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 1395	details Method at line 1395 of /src/Api/Vault/Controllers/CiphersController.cs gets a parameter from a user request from id. This parameter value flows ... ID: iOCFr11iI9znjDnv46yLfiS4aDY%3D Attack Vector

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CSRF	/src/Api/Controllers/CollectionsController.cs: 208
	CSRF	/src/Api/Vault/Controllers/CiphersController.cs: 300

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.60%. Comparing base (982957a) to head (c051776).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6720      +/-   ##
==========================================
- Coverage   54.60%   54.60%   -0.01%     
==========================================
  Files        1921     1921              
  Lines       85474    85474              
  Branches     7648     7648              
==========================================
- Hits        46677    46675       -2     
- Misses      37020    37021       +1     
- Partials     1777     1778       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claude]

Overall Assessment: APPROVE

Reviewed complete removal of feature flag pm-24033-updat-premium-subscription-page (PremiumUpgradeNewDesign constant) from Constants.cs. The feature flag has been cleanly removed with no remaining references in the codebase.