VNCConn: fix wrong keysym for Ctrl+Shift+symbol keys - #305
Open
michael-adler wants to merge 1 commit into
Open
Conversation
Ctrl-held keys collapse to ASCII C0 control codes (0..31); the revert added 96 unconditionally, correct only for Ctrl+'a'..'z'. Codes 0 and 27..31 are Ctrl+'@ [ \ ] ^ _' and need +64, so Ctrl+Shift+Minus (code 31) became DEL (127) instead of '_' (95). On Mac, Ctrl also routes non-letter keys through Cocoa's doCommandBySelector:, which drops Shift before wx ever sees the char, independent of the above. Reconstruct it via UCKeyTranslate against the live keyboard layout when Shift+Ctrl are both down.
Author
|
See also wxWidgets/wxWidgets#26810, though that isn't the whole story. VNC probably shouldn't be mapping ^C to ^c before sending to the remote host since the remote host could be configured to handle them differently, so even "corrected" wxWidgets behavior is still probably wrong for VNC. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ctrl-held keys collapse to ASCII C0 control codes (0..31); the revert added 96 unconditionally, correct only for Ctrl+'a'..'z'. Codes 0 and 27..31 are Ctrl+'@ [ \ ] ^ ' and need +64, so Ctrl+Shift+Minus (code 31) became DEL (127) instead of '' (95).
On Mac, Ctrl also routes non-letter keys through Cocoa's doCommandBySelector:, which drops Shift before wx ever sees the char, independent of the above. Reconstruct it via UCKeyTranslate against the live keyboard layout when Shift+Ctrl are both down.