Skip to content

fix(pip native inspector): Prevent NPE when no project name can be derived IDETECT-4923 #1621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shantyk wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(pip native inspector): Prevent NPE when no project name can be derived IDETECT-4923 #1621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...com/blackduck/integration/detectable/detectables/pip/inspector/PipInspectorExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,12 @@ private String getProjectName(File directory, ExecutableTarget pythonExe, File s

String projectName = providedProjectName;

if (tomlParseResult != null) {
// TODO this whole section with the toml parsing can throw NPEs at different points, add try/catch instead of ifs at each step before merging.
if (tomlParseResult != null && (tomlParseResult.getTable(PROJECT_KEY) != null)) {
logger.info("The value of the condition is: " + (tomlParseResult != null && (tomlParseResult.getTable(PROJECT_KEY) != null)));
TomlTable projectTable = tomlParseResult.getTable(PROJECT_KEY);
if(projectTable.contains(NAME_KEY)) {
logger.info("Project table is: " + projectTable);
if( projectTable!= null && projectTable.contains(NAME_KEY)) {
projectName = projectTable.getString(NAME_KEY);
}
} else if (setupFile != null && setupFile.exists()) {
Expand Down