Skip to content

fix(desktop): make bundle and updater asset naming configurable#7337

Open
bavadim wants to merge 5 commits intoblock:mainfrom
redsquad-tech:fix/desktop-bundle-naming-env
Open

fix(desktop): make bundle and updater asset naming configurable#7337
bavadim wants to merge 5 commits intoblock:mainfrom
redsquad-tech:fix/desktop-bundle-naming-env

Conversation

@bavadim
Copy link
Contributor

@bavadim bavadim commented Feb 19, 2026

Summary

This PR removes hard-coded desktop bundle/asset names from macOS bundle scripts and GitHub updater asset lookup by introducing a configurable bundle name via env.

Problem

Desktop customization and rebranding often change app bundle/archive names, but several places still assumed Goose:

  • macOS bundle/debug scripts in ui/desktop/package.json
  • updater asset lookup and downloaded filename in ui/desktop/src/utils/githubUpdater.ts

That mismatch causes friction and failures in branded distributions (scripts look for Goose.app / updater looks for Goose*.zip while release assets use a custom name).

What changed

  • Added GOOSE_BUNDLE_NAME build-time define in ui/desktop/vite.main.config.mts (default: Goose).
  • Updated ui/desktop/src/utils/githubUpdater.ts to use GOOSE_BUNDLE_NAME for release asset matching and downloaded file naming.
  • Updated macOS scripts in ui/desktop/package.json (bundle:default, bundle:alpha, bundle:intel, debug) to use GOOSE_BUNDLE_NAME instead of hard-coded Goose.

Why this approach

This follows the same configurable-by-env pattern already used for updater/publisher repository settings (GITHUB_OWNER / GITHUB_REPO) and keeps the fix minimally invasive.

Related issues

Validation

  • cd ui/desktop && npm run lint:check
  • cd ui/desktop && npm run test:run

Both passed.

AI usage

AI assistance was used to draft and apply code edits; validation was performed by running the checks above.

Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments