fix(desktop): make bundle and updater asset naming configurable#7337
Open
bavadim wants to merge 5 commits intoblock:mainfrom
Open
fix(desktop): make bundle and updater asset naming configurable#7337bavadim wants to merge 5 commits intoblock:mainfrom
bavadim wants to merge 5 commits intoblock:mainfrom
Conversation
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
Signed-off-by: Vadim Polulyakh <bavadim@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes hard-coded desktop bundle/asset names from macOS bundle scripts and GitHub updater asset lookup by introducing a configurable bundle name via env.
Problem
Desktop customization and rebranding often change app bundle/archive names, but several places still assumed
Goose:ui/desktop/package.jsonui/desktop/src/utils/githubUpdater.tsThat mismatch causes friction and failures in branded distributions (scripts look for
Goose.app/ updater looks forGoose*.zipwhile release assets use a custom name).What changed
GOOSE_BUNDLE_NAMEbuild-time define inui/desktop/vite.main.config.mts(default:Goose).ui/desktop/src/utils/githubUpdater.tsto useGOOSE_BUNDLE_NAMEfor release asset matching and downloaded file naming.ui/desktop/package.json(bundle:default,bundle:alpha,bundle:intel,debug) to useGOOSE_BUNDLE_NAMEinstead of hard-codedGoose.Why this approach
This follows the same configurable-by-env pattern already used for updater/publisher repository settings (
GITHUB_OWNER/GITHUB_REPO) and keeps the fix minimally invasive.Related issues
Validation
cd ui/desktop && npm run lint:checkcd ui/desktop && npm run test:runBoth passed.
AI usage
AI assistance was used to draft and apply code edits; validation was performed by running the checks above.