transport: plumb MaxIncomingStreams/MaxIncomingUniStreams to the shim config#74
Merged
Merged
Conversation
… config
`EthEcQuicConfig` declared `max_incoming_streams` / `max_incoming_uni_streams`
(16384) but `toQuicConfig` never read them, so the one knob Go tunes for
scale (`sim/host.go` `defaultQuicConfig`) was silently discarded. This adds
both fields to the shim `QuicConfig` and carries them through `toQuicConfig`,
with a test asserting they are no longer dropped.
The final hop — advertising a custom `initial_max_streams_{bidi,uni}` on the
wire — is not yet possible: zquic 1.7.66's `io.ServerConfig` exposes no
numeric incoming-stream limit (only `transport_params_preset`, whose
`default` advertises 1000). Honoring a custom value needs a zquic
`ServerConfig` field; the shim documents this at the `io.ServerConfig`
build site as an upstream follow-up.
Closes #65.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #65.
EthEcQuicConfigdeclaredmax_incoming_streams/max_incoming_uni_streams(16384, with a passing defaults test) buttoQuicConfignever read them — the one knob Go explicitly tunes for scale (sim/host.godefaultQuicConfig) was silently discarded.What changed
max_incoming_streams/max_incoming_uni_streamsto the shimQuicConfig(zquic_quic_shim.zig).toQuicConfignow carriesconfig.max_incoming_streams/…uni_streamsinto it, so the values are no longer dropped.toQuicConfigintoQuicConfig.Honest scope note (the remaining hop)
The values now reach the shim but cannot yet be advertised on the wire: zquic 1.7.66's
io.ServerConfigexposes no numeric incoming-stream limit — onlytransport_params_preset, whosedefaultadvertisesinitial_max_streams_{bidi,uni} = 1000(andlibp2padvertises 256 bidi / 0 uni). Honoring a custom value (e.g. 16384) needs a new zquicServerConfigfield. The shim documents this at theio.ServerConfigbuild site as an upstream follow-up.This directly fixes the "silently discarded" bug the issue names, and scopes the zquic-side work transparently.
Verified on stock Zig 0.16.0:
zig fmt --check,zig build test,zig build test-quic. README updated.