{179579733}: fix sql query plan worse for parameter binding#5948
Open
emelialei88 wants to merge 1 commit into
Open
{179579733}: fix sql query plan worse for parameter binding#5948emelialei88 wants to merge 1 commit into
emelialei88 wants to merge 1 commit into
Conversation
roborivers
approved these changes
May 18, 2026
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
truncatesc_offline_generated **quarantined**
cldeadlock
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
Signed-off-by: Emelia Lei <wlei29@bloomberg.net>
emelialei88
force-pushed
the
fix/sqlite-prepare-slow
branch
from
8b648e6 to
3f0818b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
whereLoopOutputAdjust, we callsqlite3ExprIsIntegerto adjust output number estimation for small numbers like -1, 0, 1. We always pass in 0 as the third parameter. The function would estimate based on the real value for literal values but skippedsqlite3VdbeGetBoundValuesincepParse==0. This could cause the query planner to choose a significantly worse plan when using bound parameters vs literals.Fix has been made on upstream sqlite branch-3.28.