Skip to content

fix(skills): pass --project-root to the customization resolver - #44

Merged
bmadcode merged 1 commit into
mainfrom
issue-2796-pass-project-root
Aug 31, 2026
Merged

bmadcode merged 1 commit into
mainfrom
issue-2796-pass-project-root

Conversation

@bmadcode

@bmadcode bmadcode commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Adds --project-root {project-root} to all 15 resolve_customization.py invocation sites across 10 skill files (6 agents, 4 workflows, including the workflow.on_complete terminal hooks).

Why

resolve_customization.py inferred the project root when --project-root was absent, walking up from the skill's installed directory. For a skill installed under the user's home that walk reaches ~ — and a user-level install's ~/_bmad made home look like the project. Team overrides in the real project were silently ignored: no error, no warning, just shipped defaults.

The resolver itself is fixed in bmad-code-org/BMAD-METHOD#2802. That is what actually repairs existing installs — this module ships no copy of the script and calls core's at {project-root}/_bmad/scripts/, so it inherits the fix on upgrade with nothing to do here.

This PR is the hardening half. Passing the root explicitly leaves nothing to infer, and matches resolve_config.py, which has always required the flag.

Safety

No behaviour change wherever the inference already landed correctly, which is the common case. --project-root has always existed, so there is no version skew in either direction: new skill text works against an old resolver, and old text against the new one. This can merge before or after #2802.

Refs bmad-code-org/BMAD-METHOD#2796

🤖 Generated with Claude Code

https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ

Summary by CodeRabbit

  • Bug Fixes
    • Improved customization resolution across brainstorming, problem-solving, design-thinking, innovation, presentation, and storytelling workflows.
    • Ensured project-specific settings are consistently resolved using the active project context.
    • Updated activation and completion steps to provide the correct project context throughout supported workflows.

Core's resolve_customization.py inferred the project root when the flag
was absent, and for a skill installed under the user's home that
inference walked up to ~ — where a user-level install's ~/_bmad made
home look like the project. Team overrides in the real project were
silently ignored: no error, no warning, just shipped defaults.

The resolver itself is fixed in BMAD-METHOD#2802, which is what actually
repairs existing installs since this module ships no copy of the script.
This is the hardening half: passing the root explicitly leaves nothing to
infer, and matches resolve_config.py, which has always required it.

No behaviour change where the inference already landed correctly. The
flag has always existed, so new skill text works against an old resolver
and old text against the new one.

Refs bmad-code-org/BMAD-METHOD#2796

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ
@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cdd8fa2-9a36-44a1-b1ee-7b2f29f866e4

📥 Commits

Reviewing files that changed from the base of the PR and between 0e4ff92 and 654d49b.

📒 Files selected for processing (10)
  • src/skills/bmad-cis-agent-brainstorming-coach/SKILL.md
  • src/skills/bmad-cis-agent-creative-problem-solver/SKILL.md
  • src/skills/bmad-cis-agent-design-thinking-coach/SKILL.md
  • src/skills/bmad-cis-agent-innovation-strategist/SKILL.md
  • src/skills/bmad-cis-agent-presentation-master/SKILL.md
  • src/skills/bmad-cis-agent-storyteller/SKILL.md
  • src/skills/bmad-cis-design-thinking/SKILL.md
  • src/skills/bmad-cis-innovation-strategy/SKILL.md
  • src/skills/bmad-cis-problem-solving/SKILL.md
  • src/skills/bmad-cis-storytelling/SKILL.md

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The skill instructions now pass {project-root} to customization resolver commands for agent, workflow, and workflow completion keys.

Changes

Customization resolver integration

Layer / File(s) Summary
Agent resolver commands
src/skills/bmad-cis-agent-*/SKILL.md
Agent activation commands now include --project-root {project-root}.
Workflow resolver commands
src/skills/bmad-cis-design-thinking/SKILL.md, src/skills/bmad-cis-innovation-strategy/SKILL.md, src/skills/bmad-cis-problem-solving/SKILL.md, src/skills/bmad-cis-storytelling/SKILL.md
Workflow and workflow.on_complete commands now include --project-root {project-root}.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 654d4

This change explicitly passes the project root to customization resolution, preventing project-level overrides from being silently missed while preserving behavior where root inference was already correct. No actionable merge-blocking risk remains beyond normal checks and review.

Poem

A rabbit checks each command line
The project root now travels fine
Agent paths and workflows agree
Completion steps pass it carefully
Neat little flags, as tidy as can be

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: passing --project-root to the customization resolver across the skill invocation sites.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (10 skipped: 10 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-2796-pass-project-root

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bmadcode
bmadcode merged commit 1f5ef5e into main Aug 31, 2026
20 checks passed
bmadcode added a commit that referenced this pull request Aug 31, 2026
Covers #44. Bumps .claude-plugin/marketplace.json to 0.3.2, which the
release workflow does not touch.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L8Hyqmp2giAVgEAnB49zEQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant