Checking changes to Niccoyooo instrumentation#9
Open
bnsgeyer wants to merge 25 commits into
Open
Conversation
bnsgeyer
force-pushed
the
niccoyooo-instrumentation
branch
from
15c01c3 to
0ce11e7
Compare
Owner
Author
|
@niccoyooo and @Lychee106 Here is a PR I created to better track what changes have been done. I cleaned up you new library and got it to compile. Left some notes on what you'll need to do in the changes.md file. Looks like you wont need a separate logging write method in Copter. The library already logs the data. You can adjust the current one with the data you'll log. You can pull my commits into your repo by adding my repo as a remote. then fetch the remote that your added. then use the git cherry-pick command to pull in my commits. |
bnsgeyer
force-pushed
the
niccoyooo-instrumentation
branch
from
d533875 to
79814ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR being used to check all changes made to this branch against Copter 4.4