Skip to content

Read straight into long - #110

Closed
BladedDodo wants to merge 1 commit into
bogde:masterfrom
BladedDodo:patch-1
Closed

Read straight into long#110
BladedDodo wants to merge 1 commit into
bogde:masterfrom
BladedDodo:patch-1

Conversation

@BladedDodo

Copy link
Copy Markdown

Saves reading of bytes and construction of 32 bit int, doesn't require calling of ShiftIn

Saves reading of bytes and construction of 32 bit int, doesn't require calling of ShiftIn
@electrokean

Copy link
Copy Markdown

This isn't ideal as it will not sign extend 24-bit negative values

@amotl

amotl commented Feb 21, 2019

Copy link
Copy Markdown
Contributor

Hi there,

in the spirit of #123, I'm happy that we reached a point of stability again and don't care about further optimizations that much. However, I am humbly asking about your opinion about this, @BladedDodo and @electrokean: Would it be fine to close this or do you have any strong opinions about getting this optimization merged?

With kind regards,
Andreas.

@BladedDodo

Copy link
Copy Markdown
Author

Happy for you to close it Andreas

@electrokean

Copy link
Copy Markdown

All good. I've been out of the loop of late, but thanks @amotl for the work you're doing on this.

@amotl

amotl commented Jul 14, 2019

Copy link
Copy Markdown
Contributor

Dear @BladedDodo and @bogde,

I'm just revisiting this and I believe it might be closed. @BladedDodo and @electrokean: The updated library is available via Arduino Library Manager these days.

With kind regards,
Andreas.

@electrokean

Copy link
Copy Markdown

I saw no objections from anyone. I think the OP @BladedDodo or maintaner @bogde will need to close this.

@bogde bogde closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants