Wait_any: Gracefully handle no active requests#126
Open
hirschsn wants to merge 2 commits intoboostorg:developfrom
Open
Wait_any: Gracefully handle no active requests#126hirschsn wants to merge 2 commits intoboostorg:developfrom
hirschsn wants to merge 2 commits intoboostorg:developfrom
Conversation
Member
|
Hi, sorry for the delay. One request though: do you think you could add a test to check that case ? Thanks |
Contributor
Author
|
@aminiussi Sorry for not including them in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is analogous to #117.
Current boost 1.74.0 deadlocks if wait_any is passed a range of inactive (null requests or already completed) requests.
(You may add this or derivatives of it as a test case under the boost license.)
This PR fixes this issue by explicitly keeping track of the presence of an active request. If none is present, it returns an empty status and the iterator "last".
Also, this PR changes the behavior for all trivial requests. Currently, boost-mpi throws an exception if wait_any is passed all trivial and inactive requests (nonblocking.hpp:96ff):
Boost-MPI does actually have default constructed
statusobjects that indicate an error status (cannot be queried for size, etc.). Also, MPI itself guarantees in this case to set thestatusparameter of theMPI_Waitanycall to an empty status. So, this PR also changes this behavior to return the status and the iterator "last".