Topic/gh 323 lazy ostream check printable sooner #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raffienficiaud
force-pushed
the
topic/GH-323-lazy_ostream-check-printable-sooner
branch
from
379c43f to
d67dd18
Compare
The operator() is not instantiated till later, which makes it difficult to locate an erroneous usage of <<. Place a static_assert in the ctor (copied from print_helper.hpp) to check at construction time, which will point back to the << site.
raffienficiaud
force-pushed
the
topic/GH-323-lazy_ostream-check-printable-sooner
branch
from
d67dd18 to
d3a47fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build for #323