Repository navigation
feat(activity): phone rows use the web's compact spacing (two-line preview kept) - #5123
Closed
stamp-build[bot] wants to merge 5 commits into
Closed
stamp-build[bot] wants to merge 5 commits into
stamp-build[bot] wants to merge 5 commits into
Conversation
…eview kept) Phone Activity rows take raft-ui InboxItem density="compact" as a list cell (raft-design patterns/lists.md, components/inbox-item.md): the state shape 8dp in from each side, the content 12dp inside it (20dp from the screen's edge), 8dp above and below with a 56dp minimum by touch (12dp, no minimum, with a mouse in a narrow window), rows 2dp apart with no hairline, 8dp above the first row, day headings on the 20dp content line. The two reserved excerpt lines stay. Goldens of the phone Activity rows removed for a CI re-record. Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…5369935) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
…t-ui listColumnMargin) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
… run 44680263340) Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com> Signed-off-by: sindresorhus <raft+sindresorhus@agents.stamp.build>
stamp-build
Bot
force-pushed
the
agent/sindresorhus/activity-phone-compact
branch
2 times, most recently
from
November 20, 2026 07:02
d99b08c to
0625940
Compare
Contributor
Author
|
Merged by Stamp in batch |
stamp-build
Bot
deleted the
agent/sindresorhus/activity-phone-compact
branch
November 20, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phone (narrow) Activity rows now use the web's compact list-cell spacing, raft-ui
InboxItem density="compact", as decided by artin. The phone keeps its two-line preview; only the wide layout uses one line. The wide layout was already aligned in #5073. This PR applies the sameActivityRowLayoutvalues to the phone.Values (phone, by touch): before → after
RaftRadius.Control), inset 8dp from each sidelib/list-cell.ts--cell-inset-x:8px,--cell-radiuslist-cell.ts--cell-pad-x:12px;patterns/lists.md"20px from the list's edges on a phone"inbox-item.recipe.tspointer-coarse:py-2pointer-coarse:min-h-14lists.md"lists have no dividers";inbox-item.md"Draw no line between items"lists.mdlistgap-0.5lists.mdpy-2lists.md"One edge"InboxItemLine)itemBody mt-0itemLeading size-9, compactitems-centerWith a mouse or trackpad in a narrow window (
RaftScale.Compact+RaftPointerInput.Fine), the row keeps 12dp above and below and has no minimum height. That is the web'spy-3belowmd, sincemd:pointer-fineonly applies from 768px. The inline padding stays at 12dp inside the shape.Swipe actions, unread marks, the hover Done button and day-group headings are unchanged. Swipe layers still span the full row, as
SWIPE_LAYER_CLASSdoes on the web.Web refs: raft-design
7c3dcbb3(packages/ui/src/components/inbox-item/inbox-item.recipe.ts,inbox-item.md,packages/ui/src/lib/list-cell.ts,design/patterns/lists.md); slockorigin/staginge6808e9ee(features/thread/InboxRow.tsxusesdensity="compact"at every width).Screenshots
The 21 phone Activity row goldens (
screens.activity.rows*,screens.activity.object-rows*,screens.activity.task-rows*,activity.app-bot.dm-rows*,hover.activity-row*) were re-recorded in CI (Test run 44675369935,record_screenshots=true). No other golden changed beyond tolerance.ActivityConversationRowsScreenshotTestnow lays out its rows the waySharedActivityListdoes: 8dp top padding, 2dp gap, headings on the content edge.Visual-testing
components.home.activity.results(run 44675389296, publish=false): Android and React now share the 20dp content and heading edge and have no dividers. The remaining difference is the intended two-line preview.Changeset
Needs a changeset for 1.28 after the 1.27 cut (
change-logs/1.28.0doesn't exist on main yet).