Skip to content

fix(tasks): resolve joint-channel task assignee from other server's actor (slock #14517) - #5132

Closed
stamp-build[bot] wants to merge 2 commits into
mainfrom
agent/reef/128-joint-task-assignee-actor
Closed

stamp-build[bot] wants to merge 2 commits into
mainfrom
agent/reef/128-joint-task-assignee-actor

Conversation

@stamp-build

@stamp-build stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

Reef from raft opened this pull request through Stamp
View in Stamp →


Port of botiverse/slock #14517 (verified against live botiverse/slock 11504c9eae82d84887b9bc49b1289e9f9317590f) for #wg-mobile-sync:#128:

  • Message task list (ThreadLinkedTaskProjection.kt, ThreadMessageSourceTaskList.kt):
    • Carry isJointChannel (task.channelType == "joint") on ThreadMessageSourceTaskItem so a joint-channel task resolves its remote assignee even when task.channelType == "joint" is the only joint signal (matching web task.channelType === "joint" || inJointChannel).
    • Pass memberAvatarResolver.forJointSurface(onJointChannel) to RaftMemberAvatar and resolve remote assignee display name via rememberRaftJointActor (threadMessageSourceTaskAssigneeName), keeping local roster priority and never querying actors/resolve outside joint channels or for the viewer ("You").
  • Task conversations (ThreadRouteGates.kt, ThreadPage.kt, TaskConversationHead.kt, TaskOpenSurfaces.kt):
    • Extend threadMessageSurfaceIsJoint and ThreadPage (LocalRaftJointActorSurface + messageAvatarResolver) to detect joint-channel task conversations via taskConversationTask.channelType == "joint" or taskConversationParentChannelId's directory projection.
    • Propagate isJointChannel on TaskConversationHeaderChrome so TaskConversationBarTitle resolves remote assignee avatar and accessibility label via actors/resolve on joint-channel tasks.
    • Provide LocalRaftJointActorSurface in TaskPendingConversationPage when task.channelType == "joint" so pending joint-channel task views also resolve remote faces.
  • Tests & Changeset: Added unit tests in ThreadMessageSourceTasksTest and JointBillingNoticeTest, plus change-logs/1.28.0/changesets/joint-task-assignee-actor-avatar.md (zh-CN / en / ja).

Validation

  • Local lightweight checks: git diff --check, scripts/ci/check_source_constraints.py passed.
  • Compile & tests: running on hosted CI (Test workflow; iOS compile runs on merge queue).

@stamp-build

stamp-build Bot commented Nov 20, 2026

Copy link
Copy Markdown
Contributor Author

Merged by Stamp in batch f356d08303126c2b0360de0f6b9a24cf: a89faf8 . The batch passed its required CI; this PR is closed because its commit was included by fast-forward.

Review in stamp.build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants