Repository navigation
fix(tasks): resolve joint-channel task assignee from other server's actor (slock #14517) - #5132
Closed
stamp-build[bot] wants to merge 2 commits into
Closed
stamp-build[bot] wants to merge 2 commits into
stamp-build[bot] wants to merge 2 commits into
Conversation
Contributor
Author
|
Merged by Stamp in batch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of
botiverse/slock#14517 (verified against livebotiverse/slock11504c9eae82d84887b9bc49b1289e9f9317590f) for#wg-mobile-sync:#128:ThreadLinkedTaskProjection.kt,ThreadMessageSourceTaskList.kt):isJointChannel(task.channelType == "joint") onThreadMessageSourceTaskItemso a joint-channel task resolves its remote assignee even whentask.channelType == "joint"is the only joint signal (matching webtask.channelType === "joint" || inJointChannel).memberAvatarResolver.forJointSurface(onJointChannel)toRaftMemberAvatarand resolve remote assignee display name viarememberRaftJointActor(threadMessageSourceTaskAssigneeName), keeping local roster priority and never queryingactors/resolveoutside joint channels or for the viewer ("You").ThreadRouteGates.kt,ThreadPage.kt,TaskConversationHead.kt,TaskOpenSurfaces.kt):threadMessageSurfaceIsJointandThreadPage(LocalRaftJointActorSurface+messageAvatarResolver) to detect joint-channel task conversations viataskConversationTask.channelType == "joint"ortaskConversationParentChannelId's directory projection.isJointChannelonTaskConversationHeaderChromesoTaskConversationBarTitleresolves remote assignee avatar and accessibility label viaactors/resolveon joint-channel tasks.LocalRaftJointActorSurfaceinTaskPendingConversationPagewhentask.channelType == "joint"so pending joint-channel task views also resolve remote faces.ThreadMessageSourceTasksTestandJointBillingNoticeTest, pluschange-logs/1.28.0/changesets/joint-task-assignee-actor-avatar.md(zh-CN/en/ja).Validation
git diff --check,scripts/ci/check_source_constraints.pypassed.Testworkflow; iOS compile runs on merge queue).