Repository navigation
fix(thread): seed first-frame session/provenance, fold #5139, and shrink SharedThreadRouteContentContent - #5150
Closed
stamp-build[bot] wants to merge 5 commits into
Closed
stamp-build[bot] wants to merge 5 commits into
stamp-build[bot] wants to merge 5 commits into
Conversation
…ng file…" The event-bus effects that take the image editor's Done (and the other composer events) are keyed only on the thread, so they kept the first frame's copy of uploadComposerAttachmentFiles. On that frame the session is not loaded yet, so the copy holds the upload store of account "". The upload ran and succeeded there, but the composer applies outcomes from the signed-in account's store, so the tile never left "Checking file…". Since #5104 a cached conversation renders the full page on its first frame, before the session is captured, which exposed this on Android 1.27.0. The effects now call the latest copy through rememberUpdatedState. Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ded session The external-share auto-send collector is keyed only on the thread, so it kept the first frame's performComposerSend, whose session and provenance are null before the session loads: the send was rejected (authority_changed_before_message_send) and the share never went out. It now calls the latest copy through rememberUpdatedState. Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…function references A local function reference compares equal across compositions (equals ignores the captured locals), so rememberUpdatedState's structural policy kept the first frame's copy and the previous commit had no effect. Found by Reef in the alpha's dex. Co-authored-by: bytemain <13938334+bytemain@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…and harden null-owner effects
…ers from SharedThreadRouteContentContent
stamp-build
Bot
force-pushed
the
agent/reef/thread-first-frame-session
branch
from
November 20, 2026 11:06
e150bd8 to
47d041e
Compare
Contributor
Author
|
Merged by Stamp in batch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up sweep for the Android 1.27.0 release blocker (#proj-mobile:#216), now rebased onto
main(67e5dfc7c4, which includes #5143), folding in #5139 (7407d10881..fda59fb1ca) and extracting two cohesive helpers out ofSharedThreadRouteContentContentso the combined code stays well under the 54,970-byte JVM method-size ratchet without raising the ceiling.Root Cause
DisposableEffect(eventBus, threadInstanceKey)captured frame-1uploadComposerAttachmentFilesandperformComposerSend; wrapping both inrememberUpdatedStatelambdas (not::localFun, whoseFunctionReference.equalsignores captured locals) keeps them fresh across recompositions.nullsession / provenance / slug bugs on cached opens (fix(thread): seed first-frame session/provenance, fold #5139, and shrink SharedThreadRouteContentContent #5150): since fix(thread): a cached conversation opens without flashing Loading (#171) #5104 removedLoadingShellon cached opens,SharedThreadRouteContentContentmounted on frame 1 withcurrentSession,replyCacheProvenanceOwner, andcurrentServerSlugstillnulleven thoughthreadViewModel.ensureStarted()already captured the verifiedReplyCacheProducerContextinline on the warm path:ThreadPeerReadReceipts.kt: frame-1BindOwner(null)wiped the shell-wideSharedPeerReadReceiptStoreacross every conversation.ThreadPage.kt:createAgentComputerServerResolvedlatchedtrueonnull(server_id_missing).missing_owner_provenance), immediate Reply/Task opens (stale_provenance), inline task actions, early Unsave (recordMessageUnsaved),copyMessageLink,openActionCardChannel, and frame-1 misses for app link previews, Artifact cards, Task v2 lists, collapse,@mentionsuggestions, and quoted permalinks (serverSlug = null).ThreadPageKt.SharedThreadRouteContentContentto 55,013 bytes (43 bytes over the 54,970-byte ratchet inscripts/ci/check_jvm_method_size.py).Fix
7407d10881..fda59fb1ca): explicitrememberUpdatedStatelambdas forlatestUploadComposerAttachmentFilesandlatestPerformComposerSend.65abd1d026):SharedThreadStore.kt: record this store's own inlineinitialProducerContextinstart()(cleared inclear()), exposed viaSharedThreadViewModel.initialProducerContext.ThreadPage.kt:rememberThreadProducerContext(...)seeds frame-1 session/provenance/slug fenced bydataSource.isCurrentReplyCacheProvenance(it.provenance);createAgentComputerServerIdState/ResolvedStatederived viarememberUpdatedState;toggleMessageSavedresolves owner session beforeunsaveMessage.ThreadPeerReadReceipts.kt+RaftSharedStoreProvider.kt: ignoreowner == nullinbindThreadPeerReadReceiptsOwnerand explicitly dispatchBindOwner(null)on all 4 sign-out / account-retirement / server-access-loss / scope-release paths.47d041e1c1):ObserveThreadFirstContentPerformanceGate(...)(passingthreadOpenStartedAt: () -> TimeMark?so live frame-1 reads and zero extra recompositions are preserved).ThreadTaskConversationState+rememberThreadTaskConversationState(...), moving the Task v2 header/tasks/details ViewModels and effects out ofSharedThreadRouteContentContentand collapsing 9 captured locals of theRaftForegroundBannerHosttrailing lambda into 1taskConversationobject.Verification
1.0.0-alpha+fa4f577f83, run44717091810): 1 image, 2 images, fast-entry upload, immediate Send, Reply in Thread, Open Tasks, and read receipts all passed with 0missing_owner_provenance/stale_provenance/serverSlug=null/server_id_missing.SharedThreadReplyCacheProvenanceTestandThreadPeerReadReceiptsTest.release/1.27.0alongside fix(thread): a translating message shows placeholder bars down its whole height #5141 and fix(thread): composer uploads key on the signed-in account from the first frame #5143).